Skip to content

[Tests] Remove filesystem mocks in dev-override.test.ts#7616

Open
gonzaloriestra wants to merge 1 commit into
mainfrom
tests-remove-fs-mocks-dev-override-3785740012775383200
Open

[Tests] Remove filesystem mocks in dev-override.test.ts#7616
gonzaloriestra wants to merge 1 commit into
mainfrom
tests-remove-fs-mocks-dev-override-3785740012775383200

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

@gonzaloriestra gonzaloriestra commented May 23, 2026 •
edited
Loading

WHY are these changes introduced?

This PR refactors the unit tests for devWithOverrideFile to remove global filesystem mocking, following the codebase's best practices for more robust and realistic tests.

WHAT is this pull request doing?

  • Removes vi.mock('@shopify/cli-kit/node/fs') from packages/theme/src/cli/services/dev-override.test.ts.
  • Updates tests to use inTemporaryDirectory to perform real filesystem operations.
  • Replaces manual vi.mocked calls for filesystem utilities with actual file creation using writeFile.

How to test your changes?

CI

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 3785740012775383200 started by @gonzaloriestra

@google-labs-jules
Copy link
Copy Markdown

google-labs-jules Bot commented May 23, 2026

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 23, 2026
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label May 25, 2026
@gonzaloriestra gonzaloriestra force-pushed the tests-remove-fs-mocks-dev-override-3785740012775383200 branch from 0ad9983 to 4a9365e Compare May 25, 2026 09:31
@gonzaloriestra gonzaloriestra marked this pull request as ready for review May 25, 2026 09:32
@gonzaloriestra gonzaloriestra requested review from a team as code owners May 25, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gonzaloriestra